[Cloud Posture] Agent link now has underline #141118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JordanSh
added
release_note:skip
|
Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security Posture) |
JordanSh
commented
Sep 20, 2022
| return ( | ||
| <a | ||
| // eslint-disable-next-line @elastic/eui/href-or-on-click |
There was a problem hiding this comment.
we're not the only ones that did this
orouz
reviewed
Sep 20, 2022
| return ( | ||
| <a | ||
| // eslint-disable-next-line @elastic/eui/href-or-on-click | ||
| <EuiLink |
There was a problem hiding this comment.
we need to still be able to navigate with href ("open in new tab")
orouz
approved these changes
Sep 20, 2022
|
an updated version, the row is not fully clickable, just the links. all can be opened in new tab and have underlines on hover Screen.Recording.2022-09-20.at.20.05.04.mov |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @JordanSh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before and After video
Screen.Recording.2022-09-20.at.18.19.05.mov